-
Notifications
You must be signed in to change notification settings - Fork 234
Example for geopandas line geometry: Use Natural Earth dataset, change to Asia #4229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Third option, just show line objects for a geopandas line geometry example, nothing else. So, no cities should appear 😉 . |
Yep, here for the line example we will stay with the rivers only. |
It's likely there are one or a few rivers that doesn't have geometry information. This can be avoided if we focus on the rivers in Europe only. This can be done by: |
|
I am wondering if it would be welcome to change the region from Europe to South America for the line geometry example. Then we can use Europe for an example on the point geometry. The plotting of the point geometry is straightforward, but I think it's good to show that users can pass the columns of a gdf directly to the
|
|
A suggestion regarding figures in tutorials: I think that horizontally-oriented (landscape) figures are often more effective than vertical (portrait) ones. Because they don't fill the entire screen, landscape figures enable users to see the visual aid and the relevant text side-by-side, which creates a smoother and more efficient reading flow. This approach is implemented effectively in these PyGMT tutorials: |
Hey @Esteban82. Thanks for looking at this example and your feedback. Yeah, your are right and I agree the South American map gets quite large in the gallery, which is not optimal. To get a more horizontally-orientated figure, we could use Australia or Asia as region. For Australia, there are only a few rivers for the 50 m dataset. Thus I would go with Asia.
|
|
Hi Yvonne! Yes, I agree with Asia. |
|
Sorry, but I prefer not to use the Asia map. China and India have unresolved boundary disputes, and from China’s perspective, the boundary lines in this dataset—and even in GMT’s GSHHG dataset—are incorrect. Since I am from China and leading this project, I prefer not to include any national boundary lines of China to avoid potential political sensitivities. |
No worries! This is totally fair and an important aspect. |
Yes. |






Description of proposed changes
Use the Use the Natural Earth dataset in the example for geopandas line geometry. For details see #4223 (comment).
Let's hope the request / download is more stable and this will make our docs build less often fail 🚀.
For the rivers there is only one river plotted for Europe. When changing to 50 m (instead of 110 m) I get the error
When using the subset
rivers[rivers["scalerank"] != 5]it works. Interestingly the subsetrivers_five = rivers[rivers["scalerank"] == 5]is empty. For 10 m, I do not face such an error.Related to
Fixes #4223
Preview: https://pygmt-dev--4229.org.readthedocs.build/en/4229/gallery/lines/linestrings.html
Guidelines
Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code