Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Sep 30, 2025

Need to wait for #4127.

Address #4017

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Sep 30, 2025
@seisman seisman added this to the 0.17.0 milestone Sep 30, 2025
@weiji14 weiji14 mentioned this pull request Sep 30, 2025
@weiji14
Copy link
Member

weiji14 commented Sep 30, 2025

Also need to update these:

  1. Remove tolerance from test_subplot_outside_plotting_positioning, xref Update the test_subplot_outside_plotting_positioning test and increase the RMS tolerance #2454. Might need to regenerate the plot

# Increase tolerance for compatibility with GMT 6.4, see
# https://github.com/GenericMappingTools/pygmt/pull/2454
@pytest.mark.mpl_image_compare(tolerance=4.0)
def test_subplot_outside_plotting_positioning():

  1. Remove mention of GMT 6.4 in font parameter of timestamp(), xref Add Figure.timestamp to plot the GMT timestamp logo #2208 (comment) and Allow FONT_LOGO to change font color gmt#7125:

font
Font of the timestamp and the optional label. Since the GMT logo has a fixed
height, the font sizes are fixed to be 8-point for the timestamp and 7-point for
the label. The parameter can't change the font color for GMT<=6.4.0, only the
font style.

  1. Update wording on ghostscript transparency note:

pygmt/doc/install.md

Lines 319 to 327 in 06e75f5

### Not working transparency
It is known that some combinations of GMT and Ghostscript versions cause issues,
especially regarding transparency. If the transparency doesn't work in your figures,
please check your GMT and Ghostscript versions (you can run `pygmt.show_versions()`).
We recommend:
- Ghostscript 9.53-9.56 for GMT 6.4.0 (or below)
- Ghostscript 10.03 or later for GMT 6.5.0

Base automatically changed from drop-gmt-6.4 to main September 30, 2025 03:41
@seisman seisman marked this pull request as ready for review September 30, 2025 03:42
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge once tests pass. The ghostscript note can be updated separately, I see you've already opened another branch for that.

@seisman seisman merged commit 4a9b70b into main Sep 30, 2025
23 of 28 checks passed
@seisman seisman deleted the gmt-6.4 branch September 30, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants