Skip to content

Fix the bug when passing a sequence that contains True to a parameter #3982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seisman merged 2 commits into from
Jun 24, 2025
Merged

Fix the bug when passing a sequence that contains True to a parameter #3982

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
075bfa5
Fix the bug that passing a sequence that contains True to a parameter
seisman Jun 19, 2025
919782b
Add one test
seisman Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pygmt/helpers/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,8 @@ def build_arg_list( # noqa: PLR0912
['-A1/2/3/4', '-BWSen', '-Bxaf', '-Byaf', '-C1p', '-C2p']
>>> build_arg_list(dict(B=["af", "WSne+tBlank Space"]))
['-BWSne+tBlank Space', '-Baf']
>>> build_arg_list(dict(B=[True, "+tTitle"]))
['-B', '-B+tTitle']
>>> build_arg_list(dict(F='+t"Empty Spaces"'))
['-F+t"Empty Spaces"']
>>> build_arg_list(dict(l="'Void Space'"))
Expand Down Expand Up @@ -565,7 +567,10 @@ def build_arg_list( # noqa: PLR0912
elif value is True:
gmt_args.append(f"-{key}")
elif is_nonstr_iter(value):
gmt_args.extend(f"-{key}{_value}" for _value in value)
gmt_args.extend(
f"-{key}{_value}" if _value is not True else f"-{key}"
for _value in value
)
else:
gmt_args.append(f"-{key}{value}")

Expand Down
Loading