Session.virtualfile_from_vectors: Remove the deprecated '*args' parameter [deprecated since v0.14.0] #3893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eter [deprecated since v0.14.0]
seisman
added
final review call
weiji14
approved these changes
Apr 8, 2025
Member
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
Looks ok, but do you want to wait another week before merging this (and other deprecation PRs)? Or we're confident with the release branch workflow already 🙂
Member
Author
OK with waiting another week. Will merge this PR on April 14. |
This was referenced Apr 8, 2025
michaelgrund
approved these changes
Apr 10, 2025
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3522.