-
Notifications
You must be signed in to change notification settings - Fork 235
GMTDataArrayAccessor: Support applying grid operations on the current xarray.DataArray object #3854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
9c74046
Extend GMTDataAccessor to support grid operations
seisman fe7612c
Merge branch 'main' into accessor/gridop
seisman 8b95908
Merge branch 'main' into accessor/gridop
seisman 4853128
Add more grid operations to GMTDataArrayAccessor
seisman 8d039aa
Merge branch 'main' into accessor/gridop
seisman 505c9d0
Add docstrings for the new methods
seisman f49c3d0
Fix docstrings
seisman 58ee6a1
Fix docstrings
seisman c43e6c6
Merge branch 'main' into accessor/gridop
seisman d2527ae
Merge branch 'main' into accessor/gridop
seisman 49490d5
Update docstrings
seisman db42b7a
Add equalize_hist method
seisman de29785
Merge branch 'main' into accessor/gridop
seisman a341d39
Merge branch 'main' into accessor/gridop
seisman ebed146
Merge branch 'main' into accessor/gridop
seisman e7445ea
Merge branch 'main' into accessor/gridop
seisman 48c84fe
Merge branch 'main' into accessor/gridop
seisman d602f71
Merge branch 'main' into accessor/gridop
seisman 397504b
Use functools.wraps
seisman c3c362c
Add two tests
seisman 3399025
Fix
seisman 1b2aafb
Add a period
seisman e124192
Fix a typo
seisman 98a322d
Merge branch 'main' into accessor/gridop
seisman e0ca40b
Merge branch 'main' into accessor/gridop
seisman d26b56d
Merge remote-tracking branch 'origin/accessor/gridop' into accessor/g…
seisman 5a5fa16
Avoid two unused fixtures
seisman d6aa952
Merge branch 'main' into accessor/gridop
seisman 39c8c8e
Merge branch 'main' into accessor/gridop
seisman 2d3c6b1
Use histeq for consistency
seisman c43ae14
Fix the name in tests
seisman 6fd0c50
Fix test name
seisman 7bdf385
Merge branch 'main' into accessor/gridop
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably best to keep the method name as
.gmt.grdclipinstead of.gmt.clip, because there is also https://docs.generic-mapping-tools.org/6.5/clip.html (same with the other grd* methods below), and who knows if we might use pandas accessors at some point.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if we decide to implement the pandas accessors in the future (actually, I feel it's a good idea), there are still no conflicts since the two accessors are in different namespaces. E.g.,
da.gmt.clip: Clip operation on a xr.DataArray grid/imagedf.gmt.clip: Clip operation on a pd.DataFrame object