Fix the bug for passing text strings with numeric values #3804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Added images
Modified images
Report last updated at commit 6f825cd |
weiji14
approved these changes
Feb 13, 2025
seisman
added a commit
that referenced
this pull request
Feb 14, 2025
* Add a regression text for passing strings with numeric values * Do not try to convert string array to np.datetime64 dtype * Fix the _to_numpy test for datetime strings
seisman
added a commit
that referenced
this pull request
Feb 14, 2025
* Add a regression text for passing strings with numeric values * Do not try to convert string array to np.datetime64 dtype * Fix the _to_numpy test for datetime strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
test_text_numeric_textfor the regression bug reported in The fig.text function in PyGMT does not plot text if the text is purely numeric in pygmt 0.14.1 #3803test_clib_to_numpyand add the new testtest_to_numpy_python_datetime_stringFixes #3803.