Skip to content

Conversation

@seisman seisman added the maintenance Boring but important stuff for the core devs label Jan 18, 2025
@weiji14
Copy link
Member

weiji14 commented Jan 22, 2025

Test failures on some x2sys_cross tests appear to be the same as #3194, we had some logic to handle the shape mismatches using an if sys.platform == "darwin" check, e.g. here:

https://github.com/GenericMappingTools/pygmt/blob/8a09f75cae034ab0e01e1a29e46df65a116d9508/pygmt/tests/test_x2sys_cross.py#L273-277

Maybe we can use if platform.machine() == "arm64" to handle both Ubuntu and macOS arm64 variants, xref https://docs.python.org/3/library/platform.html#platform.machine?

@seisman
Copy link
Member Author

seisman commented Jan 26, 2025

Maybe we can use if platform.machine() == "arm64" to handle both Ubuntu and macOS arm64 variants, xref https://docs.python.org/3/library/platform.html#platform.machine?

platform.machine() returns arm64 on macOS ARM and aarch64 on Linux ARM. So, if platform.machine() in {"aarch64", "arm64"}: works, but there are still two failures related to contour.

@seisman
Copy link
Member Author

seisman commented Feb 3, 2025

Maybe we can use if platform.machine() == "arm64" to handle both Ubuntu and macOS arm64 variants, xref https://docs.python.org/3/library/platform.html#platform.machine?

platform.machine() returns arm64 on macOS ARM and aarch64 on Linux ARM. So, if platform.machine() in {"aarch64", "arm64"}: works, but there are still two failures related to contour.

I've marked the two 'contour' tests as xfail on Linux ARM and now all tests pass.

@seisman seisman added this to the 0.15.0 milestone Feb 3, 2025
@seisman seisman added the needs review This PR has higher priority and needs review. label Feb 3, 2025
@seisman seisman merged commit e9792fe into main Feb 6, 2025
22 checks passed
@seisman seisman deleted the ci/linux-arm branch February 6, 2025 23:21
@seisman seisman removed the needs review This PR has higher priority and needs review. label Feb 6, 2025
weiji14 added a commit that referenced this pull request Feb 10, 2025
Fixes error `Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run` on the ubuntu-24.04-arm job. Patches #3778
weiji14 added a commit that referenced this pull request Feb 10, 2025
Fixes error `Failed to CreateArtifact: Received non-retryable error:
Failed request: (409) Conflict: an artifact with this name already exists
on the workflow run` on the ubuntu-24.04-arm job. Patches #3778

---------

Co-authored-by: Dongdong Tian <[email protected]>
@weiji14 weiji14 mentioned this pull request Apr 14, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants