Allow passing in scalar number to x and y in plot #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables users to plot a single symbol easily by just giving an x and y coordinate e.g. `fig.plot(x=1.2, y=1.4)` instead of having to wrap things in a list (e.g. `fig.plot(x=[1.2], y=[1.4])`. This makes it consistent with `pygmt.Figure.text`.
Member
Author
|
This should address your comment at #321 (comment) @liamtoney. |
liamtoney
approved these changes
Nov 8, 2019
Member
liamtoney
left a comment
liamtoney
left a comment
There was a problem hiding this comment.
Looks good to me, aligns with the text() method which makes sense.
Member
Author
|
Cool, I'll just wait to hear back from #255. |
seisman
reviewed
Nov 9, 2019
pygmt/tests/test_plot.py
Outdated
|
|
||
|
|
||
| @pytest.mark.mpl_image_compare | ||
| def test_plot_symbols(): |
Member
There was a problem hiding this comment.
Maybe a better name for this test, test_plot_scalar_xy?
seisman
approved these changes
Nov 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Enables users to plot a single symbol easily by just giving an x and y coordinate e.g.
fig.plot(x=1.2, y=1.4)instead of having to wrap things in a list (e.g.fig.plot(x=[1.2], y=[1.4]). This makes it consistent withpygmt.Figure.text.Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.