clib.session: Add the GMT_SESSION_NOGDALCLOSE flag to keep GDAL open #3672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
bug
weiji14
approved these changes
Dec 4, 2024
Member
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
Nice finding, and easy enough to fix luckily!
seisman
removed
needs review
seisman
added a commit
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in geopandas/pyogrio#448 (comment), the errors we see in #3301, is because GMT destroys the GDAL drivers registered by pyogrio or rasterio.
To avoid GMT destroying the GDAL drivers, we need to add the
GMT_SESSION_NOGDALCLOSEflag when creating sessions.The same change is applied in #3305 and it works well.
xref:
Closes geopandas/pyogrio#448.
Closes #3301.