Skip to content

GMT_DATASET: Refactor nested classes to improve code readability #3653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
seisman merged 1 commit into from
Nov 27, 2024
Merged

GMT_DATASET: Refactor nested classes to improve code readability #3653

seisman merged 1 commit into from
Nov 27, 2024

Conversation

@seisman
Copy link
Member

@seisman seisman commented Nov 26, 2024 •
edited
Loading

The GMT_DATASET data structure was originally added in #2729, with nested classes defined like GMT_DATASET->GMT_DATATABLE->GMT_DATASEGMENT.

As initially pointed out in #2729 (comment), the nested classes are difficult to read and maintain.

This PR moves the GMT_DATATABLE/GMT_DATASEGMENT classes outside of the GMT_DATASET class.

@seisman seisman added maintenance Boring but important stuff for the core devs needs review This PR has higher priority and needs review. labels Nov 26, 2024
@seisman seisman added this to the 0.14.0 milestone Nov 26, 2024
@seisman seisman merged commit 988746b into main Nov 27, 2024
24 checks passed
@seisman seisman deleted the datatypes/dataset branch November 27, 2024 01:01
@seisman seisman removed the needs review This PR has higher priority and needs review. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees

No one assigned

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Milestone

0.14.0

Development

Successfully merging this pull request may close these issues.

3 participants

@seisman @weiji14