Refactor the _get_module_version function using importlib and add two more tests #3538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
seisman
force-pushed
the
refactor/show_versions
branch
2 times, most recently
from
8d02283 to
c6b3c70
Compare
seisman
commented
Oct 19, 2024
| "ghostscript": _get_ghostscript_version(), | ||
| } | ||
| ) | ||
| requirements = [Requirement(v).name for v in requires("pygmt")] + ["gdal"] # type: ignore[union-attr] |
Member
Author
There was a problem hiding this comment.
Previously, we have to use _get_module_version("osgeo.gdal"), now we can use _get_module_version("gdal").
Member
There was a problem hiding this comment.
Nice to see that importlib.metadata.version("gdal") works!
seisman
force-pushed
the
refactor/show_versions
branch
from
c6b3c70 to
86daafb
Compare
weiji14
approved these changes
Oct 20, 2024
| "ghostscript": _get_ghostscript_version(), | ||
| } | ||
| ) | ||
| requirements = [Requirement(v).name for v in requires("pygmt")] + ["gdal"] # type: ignore[union-attr] |
Member
There was a problem hiding this comment.
Nice to see that importlib.metadata.version("gdal") works!
michaelgrund
approved these changes
Oct 21, 2024
seisman
removed
needs review
seisman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The private
_get_module_versionfunction was initially added 4 years ago in PR #466. At that time, we supported Python 3.6-3.8 andimportlib.metadatawas not available yet.importlib.metadatawas added in Python 3.8. With this module, getting package version can be greatly simplified.This PR simplifies the
_get_module_versionfunction and also add two more tests related to Ghostscript to increase code coverage by 0.16% (now we reach 98.49%).Without optional packages:
With optional packages: