GeoPandas: Improve the interger overflow check using np.iinfo #3518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2841 for context. In that PR, we check if there are integer overflow issues by checking if the absolute maximum of a column is greater than 2^31-1 = 2147483647, which is not 100% correct.
For int32 dtype, the allowed min/max values are:
Instead, we should check if the max value > 2147483647 or the min value < -2147483648.
This PR improve the way for checking integer overflow.
Supersede PR #2841.