Document the built-in patterns in the Technical Reference section #3466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
commented
Sep 29, 2024
Member
yvonnefroehlich
left a comment
yvonnefroehlich
left a comment
There was a problem hiding this comment.
Nice addition to the "Technical Reference" section. Will look at this PR tomorrow (or in the next days) in more detail.
Co-authored-by: Yvonne Fröhlich <[email protected]>
Co-authored-by: Yvonne Fröhlich <[email protected]>
yvonnefroehlich
approved these changes
Oct 4, 2024
Member
yvonnefroehlich
left a comment
yvonnefroehlich
left a comment
There was a problem hiding this comment.
Looks good to me (besides the minor comment)!
Co-authored-by: Yvonne Fröhlich <[email protected]>
seisman
added
final review call
michaelgrund
approved these changes
Oct 4, 2024
Co-authored-by: Michael Grund <[email protected]>
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: