Session.virtualfile_in: Deprecate parameter 'required_z'. Use 'mincols' instead (will be removed in v0.20.0) #3369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
force-pushed
the
refactor/virtualfile_in
branch
2 times, most recently
from
f1e6aca to
9e78da0
Compare
seisman
changed the title
seisman
force-pushed
the
refactor/virtualfile_in
branch
2 times, most recently
from
2a1db22 to
b33476c
Compare
seisman
force-pushed
the
refactor/data_kind
branch
from
bca59f5 to
808755d
Compare
seisman
changed the title
seisman
force-pushed
the
refactor/virtualfile_in
branch
from
d7ca533 to
feddd9c
Compare
seisman
force-pushed
the
refactor/virtualfile_in
branch
from
feddd9c to
2d55e5a
Compare
6 tasks
seisman
commented
Mar 10, 2025
pygmt/helpers/utils.py
Outdated
| GMTInvalidInput | ||
| If the data input is not valid. | ||
| """ | ||
| required_z = ncols >= 3 |
Member
Author
There was a problem hiding this comment.
This is just a temporary fix. Will refactor _validate_data_input in #3818.
seisman
changed the title
seisman
added
needs review
weiji14
approved these changes
Apr 27, 2025
Member
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
Debating on whether to call the parameter mincols instead of ncols, but leave it up to you to decide.
seisman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3836.
This PR removes the
required_zparameter and add a new parametermincols.required_z=Truemeansmincols=3.