Skip to content

Patch the callback print function to suppress the UnicodeDecodeError #3367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seisman merged 2 commits into from
Aug 5, 2024
Merged

Patch the callback print function to suppress the UnicodeDecodeError #3367

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14aaba8
Patch the callback print function to suppress the UnicodeDecodeError
seisman Aug 4, 2024
c0326ef
Merge branch 'main' into printfunc
seisman Aug 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions pygmt/clib/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,10 +379,14 @@ def print_func(file_pointer, message): # noqa: ARG001
We'll capture the messages and print them to stderr so that they will show
up on the Jupyter notebook.
"""
message = message.decode().strip()
# Have to use try..except due to upstream GMT bug in GMT <= 6.5.0.
# See https://github.com/GenericMappingTools/pygmt/issues/3205.
try:
message = message.decode().strip()
except UnicodeDecodeError:
return 0
self._error_log.append(message)
# flush to make sure the messages are printed even if we have a
# crash.
# Flush to make sure the messages are printed even if we have a crash.
print(message, file=sys.stderr, flush=True) # noqa: T201
return 0

Expand Down