-
Notifications
You must be signed in to change notification settings - Fork 234
Move projection table to Technical References #3356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/format |
doc/techref/index.md
Outdated
| :maxdepth: 1 | ||
| encodings.md | ||
| projections.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be .rst unless you want to convert it to markdown
| projections.md | |
| projections.rst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed in b351314.
I would prefer to have a separate PR for rewriting the projection table to markdown.
seisman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me except one comment
Co-authored-by: Dongdong Tian <[email protected]>
| sphinx-copybutton | ||
| sphinx-design | ||
| sphinx-gallery<0.17.0 | ||
| sphinx-gallery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if we should have two PRs:
- one for moving the projection table to fix issue Documentation building fails with sphinx-gallery 0.17.0 #3346
- one for unpinning the sphinx-gallery version to revert PR Temporarily pin sphinx-gallery<0.17.0 #3350
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one PR is OK
Description of proposed changes
Since Sphinx-Gallery 0.17.0, building the Documentation fails (see #3346 (comment)). It seems like the problem is the
pygmt/examples/projections/tablefolder which only contains the README file with the projection table (see #3346 (comment)). To fix this and get rid of thetablefolder, this PR moves the projection table to the "Technical References".Fixes #3346
Previews
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code