Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Jun 26, 2024

In 45ff5a4, I set the parameter engine="pyogrio" so that geopandas would use pyogrio instead of fiona.

The conda environments diff a little:

diff gpd-0.14.txt gpd-1.0.txt
61d60
<     fiona                          1.9.6         py312h32ad294_3          conda-forge
76,77c75,76
<     geopandas                      0.14.4        pyhd8ed1ab_0             conda-forge
<     geopandas-base                 0.14.4        pyha770c72_0             conda-forge
---
>     geopandas                      1.0.0         pyhd8ed1ab_0             conda-forge
>     geopandas-base                 1.0.0         pyha770c72_0             conda-forge
144d142
<     libspatialindex                2.0.0         he02047a_0               conda-forge
220d217
<     rtree                          1.2.0         py312h3ed4c40_1          conda-forge

So it's likely something wrong with geopandas 1.0, but not sure why I can't reproduce it locally. The Tests workflow also have geopandas 1.0 installed but all tests pass (see https://github.com/GenericMappingTools/pygmt/actions/runs/9671820457/job/26701186881).

Maybe we just need to wait for a few days and see if there are any upstream fixes/changes. This PR pins geopandas<1.0 in the Docs workflow so that the Docs build passes.

Address #3301

@seisman seisman changed the title Debug issue #3301 CI: Temporarily pin geopandas<1.0 in the Docs workflow Jun 26, 2024
@seisman seisman added this to the 0.13.0 milestone Jun 26, 2024
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. labels Jun 26, 2024
@seisman seisman marked this pull request as ready for review June 26, 2024 17:02
@seisman seisman merged commit cdf4902 into main Jun 28, 2024
@seisman seisman deleted the ci/docs branch June 28, 2024 06:47
@seisman seisman removed the needs review This PR has higher priority and needs review. label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants