-
Notifications
You must be signed in to change notification settings - Fork 234
pygmt.show_versions: Warn about incompatible ghostscript versions #3244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1e4b338
pygmt.show_versions: Warn about incompatible ghostscript versions
seisman 83b7dca
Merge branch 'main' into refactor/show_versions
seisman 6e5de08
Merge branch 'main' into refactor/show_versions
seisman 55b4c6f
Merge branch 'main' into refactor/show_versions
seisman 53b93a4
Merge branch 'main' into refactor/show_versions
seisman 8410f7c
Merge branch 'main' into refactor/show_versions
seisman ddcb3c7
Merge branch 'main' into refactor/show_versions
seisman f6cd136
Update pygmt/__init__.py
seisman 4e4a22f
Merge branch 'main' into refactor/show_versions
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
pygmt.print_clib_infofunction was initially added in #176 but has been replaced bypygmt.show_versionsin #466 (first appear in v0.1.2).In this PR, a new private function
_get_clib_infois added which returns a dictionary instead of printing a long string.It's time to retire the
print_clib_infofunction. Since it's rarely used, I think we can just remove it without a deprecation warning. Of course, we should do it in a separate PR so that at least we have a deprecation entry in the v0.13.0 changelog.