Skip to content

Conversation

@michaelgrund
Copy link
Member

Description of proposed changes

This PR removes the deprecated justification parameter from Figure.timestamp (deprecated since v0.11.0).

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@michaelgrund michaelgrund added the deprecation Deprecating a feature label May 2, 2024
@michaelgrund michaelgrund added this to the 0.13.0 milestone May 2, 2024
@michaelgrund michaelgrund marked this pull request as draft May 2, 2024 08:44
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label May 5, 2024
@michaelgrund michaelgrund marked this pull request as ready for review May 5, 2024 12:05
@seisman seisman merged commit bfe033b into main May 6, 2024
@seisman seisman deleted the rem-depr-timestamp branch May 6, 2024 00:48
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants