GMT_DATASET: Add workaround for None values in the trailing text #3174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
force-pushed
the
dataset/none-string
branch
2 times, most recently
from
014561d to
d6ffe1a
Compare
seisman
force-pushed
the
dataset/none-string
branch
from
d6ffe1a to
056fe4c
Compare
seisman
commented
Apr 16, 2024
weiji14
approved these changes
Apr 16, 2024
Member
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
A couple of minor suggestions.
| "It's likely caused by an upstream GMT API bug. " | ||
| "Please consider reporting to us." | ||
| ) | ||
| warnings.warn(msg, category=RuntimeWarning, stacklevel=1) |
Member
There was a problem hiding this comment.
Suggested change
| warnings.warn(msg, category=RuntimeWarning, stacklevel=1) | |
| warnings.warn(msg, category=RuntimeWarning, stacklevel=2) |
Member
Author
There was a problem hiding this comment.
stacklevel=1 makes more sense here.
stacklevel=1:
pygmt/datatypes/dataset.py:166: RuntimeWarning: The trailing text column contains `None' values and has been replace with an empty string to avoid TypeError exceptions. It's likely caused by an upstream GMT API bug. Please consider reporting to us.
warnings.warn(msg, category=RuntimeWarning, stacklevel=1)
stacklevel=2:
pygmt/clib/session.py:1940: RuntimeWarning: The trailing text column contains `None' values and has been replace with an empty string to avoid TypeError exceptions. It's likely caused by an upstream GMT API bug. Please consider reporting to us.
return result.to_strings()
Co-authored-by: Wei Ji <[email protected]>
seisman
added
final review call
seisman
removed
the
final review call
seisman
added a commit
that referenced
this pull request
Apr 16, 2024
Co-authored-by: Wei Ji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Workaround for #3170. A test is also added.