Skip to content

Conversation

@yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Apr 10, 2024

Description of proposed changes

Switch from the tibdex/github-app-token action to generate PAT token which are used in the /format slash command to the official GitHub action for this purpose (https://github.com/actions/create-github-app-token).

Fixes #3164

@yvonnefroehlich yvonnefroehlich added the maintenance Boring but important stuff for the core devs label Apr 10, 2024
@yvonnefroehlich yvonnefroehlich added this to the 0.12.0 milestone Apr 10, 2024
@seisman
Copy link
Member

seisman commented Apr 10, 2024

/format

@seisman
Copy link
Member

seisman commented Apr 10, 2024

The /slash command can only trigger the workflow in the main branch, so there is no easy way to test if it works in PRs or forks. To test it, you need to push the same changes into the main branch in your own fork, open a PR to test it, and also need to ask someone else to submit a PR from a fork to test it.

The whole process is tedious (I have done it several times), so I think we should just merge this PR in and if anything doesn't work as expected, we should either fix it or revert it.

@seisman seisman merged commit b3e0048 into main Apr 10, 2024
@seisman seisman deleted the switch-app-token branch April 10, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to official GitHub action for managing app tokens

3 participants