Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Feb 19, 2024

We used the find command to find all files in the current directory and exclude the .git directory. The find command is very long and difficult to understand/maintain.

Instead, we can use git ls-files to list all git-tracked files.

ref: https://stackoverflow.com/a/41085442

Patches #736

@seisman
Copy link
Member Author

seisman commented Feb 19, 2024

/format

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Feb 19, 2024
@seisman seisman changed the title Use 'git ls-files' to list all git tracked files CI: Use 'git ls-files' to list all git tracked files Feb 19, 2024
@seisman seisman added the needs review This PR has higher priority and needs review. label Feb 19, 2024
@seisman seisman added this to the 0.12.0 milestone Feb 19, 2024
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more simpler, thanks!

@seisman seisman merged commit ad4a8d1 into main Feb 20, 2024
@seisman seisman deleted the find-ls-files branch February 20, 2024 14:42
@seisman seisman removed the needs review This PR has higher priority and needs review. label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants