Skip to content

Conversation

@michaelgrund
Copy link
Member

Description of proposed changes

This PR removes the deprecated bit_color parameter from Figure.grdimage (deprecated since v0.8.0).

Related to #3033

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@seisman
Copy link
Member

seisman commented Feb 2, 2024

Prefer to a PR title like:

Figure.grdimage: Remove deprecated parameter 'bit_color', use 'bitcolor' instead (deprecated since v0.8.0)

@seisman seisman added this to the 0.12.0 milestone Feb 2, 2024
@seisman
Copy link
Member

seisman commented Feb 3, 2024

We had a typo at

* Figure.image: Deprecate parameter "bit_color" to "bitcolor" (remove in v0.12.0) ([#2635](https://github.com/GenericMappingTools/pygmt/pull/2635))

Please change Figure.image to Figure.grdimage in this file.

@michaelgrund michaelgrund changed the title Remove parameter bit_color from Figure.grdimage, use bitcolor instead (deprecated since v0.8.0) Figure.grdimage: Remove deprecated parameter 'bit_color', use 'bitcolor' instead (deprecated since v0.8.0) Feb 5, 2024
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Feb 5, 2024
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Feb 6, 2024
@seisman seisman merged commit 97ba1a0 into main Feb 6, 2024
@seisman seisman deleted the rem-depr-grdimage branch February 6, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants