Skip to content

Conversation

@michaelgrund
Copy link
Member

@michaelgrund michaelgrund commented Feb 2, 2024

Description of proposed changes

This PR removes the deprecated color parameter from Figure.wiggle and corresponding tests (deprecated since v0.8.0).

Related to #3033

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@michaelgrund michaelgrund added the deprecation Deprecating a feature label Feb 2, 2024
@michaelgrund michaelgrund added this to the 0.12.0 milestone Feb 2, 2024
@michaelgrund michaelgrund changed the title Remove parameter color from Figure.wiggle, use fillpositive/fillnegative instead (deprecated since v0.8.0) Figure.wiggle: Remove parameter 'color', use fillpositive/fillnegative instead (deprecated since v0.8.0) Feb 5, 2024
@michaelgrund michaelgrund changed the title Figure.wiggle: Remove parameter 'color', use fillpositive/fillnegative instead (deprecated since v0.8.0) Figure.wiggle: Remove deprecated parameter 'color', use fillpositive/fillnegative instead (deprecated since v0.8.0) Feb 5, 2024
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Feb 5, 2024
@seisman seisman merged commit a868fc6 into main Feb 6, 2024
@seisman seisman deleted the rem-depr-wiggle branch February 6, 2024 10:09
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants