CI: Run "GMT Dev Tests" if PR is labeled with 'run/test-gmt-dev' #2960
Conversation
seisman
added
maintenance
seisman
added
run/test-gmt-dev
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
Just two comments, but should be ok if you have a good answer for it 😁
.github/workflows/ci_tests_dev.yaml
Outdated
| # branches: [ main ] | ||
| pull_request: | ||
| types: [ready_for_review] | ||
| types: [ labeled, synchronize ] |
There was a problem hiding this comment.
+1 to this. We originally set "GMT Dev Tests" to run when the PR is ready for review in PR #831, but that might have been a bit of a waste of CI resources to be honest.
There was a problem hiding this comment.
I've changed the types to types: [ opened, reopened, labeled, synchronize ], following PR #2958.
| **Slash Commands** | ||
|
|
||
| You can write slash commands (`/command`) in the first line of a comment to perform | ||
| specific operations. Supported slash commands are: | ||
| specific operations. Supported slash command is: | ||
|
|
||
| - `/format`: automatically format and lint the code | ||
| - `/test-gmt-dev`: run full tests on the latest GMT development version |
There was a problem hiding this comment.
Similar to my comment at #2958 (comment), should we still document this somewhere so that contributors/maintainers know to request that the run/test-gmt-dev label gets added to PRs that require it? Or just rely on maintainers to know when to set the label?
There was a problem hiding this comment.
weiji14
added
final review call
seisman
removed
the
final review call
Description of proposed changes
Similar to #2958.
Slash command
/test-gmt-devis no longer supported. To enable the "GMT Dev Tests" workflow, just add therun/test-gmt-devlabel (needs written permission to this repository).