Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Jan 2, 2024

Description of proposed changes

Implement the idea proposed in #2937 (comment).

Changes in this PR:

  • Move the download_test_data function from pygmt/helpers/testing.py into a separate file pygmt/helpers/caching.py and rename it to cache_data.py
  • Update the cache_data workflow so that it's automatically triggered if pygmt/helpers/caching.py or .github/workflows/cache_data.yaml changes.

@seisman seisman added maintenance Boring but important stuff for the core devs needs review This PR has higher priority and needs review. labels Jan 2, 2024
@seisman seisman added this to the 0.11.0 milestone Jan 2, 2024
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 2, 2024

CodSpeed Performance Report

Merging #2939 will improve performances by 23.38%

Comparing cache-data (24bb4fe) with main (da36673)

Summary

⚡ 1 improvements
✅ 63 untouched benchmarks

Benchmarks breakdown

Benchmark main cache-data Change
test_sph2grd_no_outgrid 4.7 s 3.8 s +23.38%

@michaelgrund michaelgrund added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jan 3, 2024
Co-authored-by: Michael Grund <[email protected]>
Co-authored-by: Yvonne Fröhlich <[email protected]>
@seisman seisman merged commit 69adbef into main Jan 3, 2024
@seisman seisman deleted the cache-data branch January 3, 2024 10:34
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants