-
Notifications
You must be signed in to change notification settings - Fork 235
Add zoom_adjust parameter to pygmt.datasets.load_tile_map and Figure.tilemap #2934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5ca369e
Add zoom_adjust param to pygmt.datasets.load_tile_map and Figure.tilemap
weiji14 27669da
Merge branch 'main' into tilemap_zoom_adjust
weiji14 e48c08d
Document that zoom_adjust requires contextily>=1.5.0
weiji14 b428d12
Raise error if zoom_adjust parameter is used with contextily<1.5.0
weiji14 ddb0351
Fix UnboundLocalError
weiji14 5cbbccb
Merge branch 'main' into tilemap_zoom_adjust
weiji14 c36deff
Rewrap docstring to 88 characters
weiji14 f0c95d8
Add type hint for zoom_adjust parameter
weiji14 70a4c83
Fix typecheck by using np.array constructor instead of np.uint8
weiji14 0b01664
Change directive for zoom_adjust from versionadded to note
weiji14 32c04f8
Use note and important admonitions in other parts of the docstring
weiji14 9170ea0
Rely on sphinx-autodoc-typehints
weiji14 90a4d4f
Remove mention of Optional from zoom_adjust docstring
weiji14 c141db5
Use double backticks around zoom_adjust
weiji14 dfd43b6
Use double backticks around zoom_adjust again
weiji14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to also include
zoom,source,ll,waitandmax_retriesincontextily_kwargs?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mm, not really necessary. I only made the
contextily_kwargsdict to make things backwards compatible withcontextily<1.5.0.