Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Dec 11, 2023

Description of proposed changes

Address #2812.

Preview: https://pygmt-dev--2867.org.readthedocs.build/en/2867/api/index.html#datasets

Changing registration=None to either

registration: Literal["gridline", "pixel", None] = None,

or

registration: Literal["gridline", "pixel"] = "gridline",

For datasets like earth_age, earth_geoid and earth_mask, the gridline-registrated version exists for all resolutions, thus the default registration should always be gridline, rather than None.

@seisman seisman added maintenance Boring but important stuff for the core devs needs review This PR has higher priority and needs review. typing Type hints and static type checking labels Dec 11, 2023
@seisman seisman added this to the 0.11.0 milestone Dec 11, 2023
@seisman seisman requested a review from a team December 13, 2023 06:10
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. final review call This PR requires final review and approval from a second reviewer labels Dec 14, 2023
@seisman seisman enabled auto-merge (squash) December 15, 2023 04:06
@seisman seisman disabled auto-merge December 15, 2023 04:06
@seisman seisman merged commit c31a913 into main Dec 15, 2023
@seisman seisman deleted the typehints/registration branch December 15, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs typing Type hints and static type checking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants