Skip to content

Improve the error messages for unsupported numpy dtypes #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seisman merged 4 commits into from
Dec 7, 2023
Merged

Improve the error messages for unsupported numpy dtypes #2856

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f8929bb
Improve the error messages for unsupported numpy dtypes
seisman Dec 6, 2023
94ed349
Order dtypes alphabetically
seisman Dec 7, 2023
c5ca123
np.complex256 is not supported on Windows
seisman Dec 7, 2023
578daf1
Fix dtype names
seisman Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pygmt/clib/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,8 +834,11 @@ def _check_dtype_and_dim(self, array, ndim):
# Check that the array has a valid/known data type
if array.dtype.type not in DTYPES:
try:
# Try to convert any unknown numpy data types to np.datetime64
array = array_to_datetime(array)
if array.dtype.type is np.object_:
# Try to convert unknown object type to np.datetime64
array = array_to_datetime(array)
else:
raise ValueError
except ValueError as e:
raise GMTInvalidInput(
f"Unsupported numpy data type '{array.dtype.type}'."
Expand Down
30 changes: 20 additions & 10 deletions pygmt/tests/test_clib_put_vector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,16 +170,26 @@ def test_put_vector_invalid_dtype():
"""
Check that it fails with an exception for invalid data types.
"""
with clib.Session() as lib:
dataset = lib.create_data(
family="GMT_IS_DATASET|GMT_VIA_VECTOR",
geometry="GMT_IS_POINT",
mode="GMT_CONTAINER_ONLY",
dim=[2, 3, 1, 0], # columns, rows, layers, dtype
)
data = np.array([37, 12, 556], dtype="object")
with pytest.raises(GMTInvalidInput):
lib.put_vector(dataset, column=1, vector=data)
for dtype in [
np.bool_,
np.bytes_,
np.complex64,
np.complex128,
np.complex256,
np.float16,
np.float128,
np.object_,
]:
with clib.Session() as lib:
dataset = lib.create_data(
family="GMT_IS_DATASET|GMT_VIA_VECTOR",
geometry="GMT_IS_POINT",
mode="GMT_CONTAINER_ONLY",
dim=[2, 3, 1, 0], # columns, rows, layers, dtype
)
data = np.array([37, 12, 556], dtype=dtype)
with pytest.raises(GMTInvalidInput, match="Unsupported numpy data type"):
lib.put_vector(dataset, column=1, vector=data)


def test_put_vector_wrong_column():
Expand Down