Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Nov 19, 2023

Description of proposed changes

Address #2770 (comment).

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs needs review This PR has higher priority and needs review. labels Nov 19, 2023
@seisman seisman added this to the 0.11.0 milestone Nov 19, 2023
@seisman seisman requested a review from a team November 20, 2023 08:21
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Nov 20, 2023
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a nice 5 years using black (since #186), so a bit sad to see it get replaced, but time to move on!

@seisman seisman merged commit 519fd03 into main Nov 20, 2023
@seisman seisman deleted the ruff/black branch November 20, 2023 23:39
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants