-
Notifications
You must be signed in to change notification settings - Fork 234
pyarrow: Check compatibility of pyarrow-backed pandas objects with numeric dtypes #2774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
de36c6c
7a43e7b
06739ef
88ce36d
83ed447
ad99cab
a5284fc
8b28ba4
95d2b8a
5adcba6
3ca0288
6d50a23
1783c7c
62d22cb
a275825
71946f8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ | |
| """ | ||
| import numpy.testing as npt | ||
| import pandas as pd | ||
| import pandas.util._test_decorators as td | ||
| import pytest | ||
| from pygmt import Figure, info, makecpt, which | ||
|
|
||
|
|
@@ -141,6 +142,24 @@ def test_geopandas_plot3d_non_default_circle(): | |
| "int64", | ||
| pd.Int32Dtype(), | ||
| pd.Int64Dtype(), | ||
| pytest.param( | ||
| "int32[pyarrow]", | ||
| marks=[ | ||
| td.skip_if_no(package="pyarrow"), | ||
| pytest.mark.xfail( | ||
| reason="geopandas doesn't support writing columns with pyarrow dtypes to OGR_GMT yet." | ||
| ), | ||
| ], | ||
| ), | ||
| pytest.param( | ||
| "int64[pyarrow]", | ||
| marks=[ | ||
| td.skip_if_no(package="pyarrow"), | ||
| pytest.mark.xfail( | ||
| reason="geopandas doesn't support writing columns with pyarrow dtypes to OGR_GMT yet." | ||
| ), | ||
| ], | ||
| ), | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So geopandas.GeoDataFrame objects with columns that have pyarrow dtypes can't be plotted in PyGMT yet, because we write them to a temporary OGR_GMT file, and |
||
| ], | ||
| ) | ||
| @pytest.mark.mpl_image_compare(filename="test_geopandas_plot_int_dtypes.png") | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.