Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Oct 10, 2023

Description of proposed changes

This PR is based on the feature implemented in PR #2729, so we need to merge #2729 first and change the base branch to "main" before reviewing this PR seriously. This PR is opened so that we can better verify the implementation in PR #2729 is correct and can be applied to multiple methods/functions.

Changes in this PR:

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman changed the title WIP: pygmt.grdtrack: pygmt.grdtrack: Support consistent table-like outputs POC: pygmt.grdtrack: pygmt.grdtrack: Support consistent table-like outputs Oct 11, 2023
@seisman seisman merged commit 87f4cf0 into datatypes/gmtdataset Oct 25, 2023
@seisman seisman deleted the tempfile/grdtrack branch October 25, 2023 02:44
@seisman seisman changed the title POC: pygmt.grdtrack: pygmt.grdtrack: Support consistent table-like outputs pygmt.grdtrack: Support consistent table-like outputs Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants