Skip to content

Conversation

@yvonnefroehlich
Copy link
Member

Description of proposed changes

This PR aims to update the Contributors Guide regarding the position of the thumbnail figure comment.
For context see: #2662 (comment)

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@yvonnefroehlich yvonnefroehlich added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Sep 9, 2023
@yvonnefroehlich yvonnefroehlich added this to the 0.11.0 milestone Sep 9, 2023
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Sep 9, 2023
@yvonnefroehlich yvonnefroehlich self-assigned this Sep 9, 2023
@seisman seisman merged commit bb400f0 into main Sep 10, 2023
@seisman seisman deleted the update-contrib-guide-position-thumbnail branch September 10, 2023 10:10
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants