Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Apr 21, 2023

Description of proposed changes

  1. Do not use the default channel when building docs
  2. Move pip as a dev dependency
  3. Move ipython as an optional dependency.

The changes in this PR were initially made in PR #2435. I cherry-picked these changes and made a separate PR to make PR #2435 smaller and thus easier to review.

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 21, 2023
@seisman seisman added this to the 0.10.0 milestone Apr 21, 2023
@seisman seisman added the needs review This PR has higher priority and needs review. label Apr 21, 2023
@seisman seisman changed the title Move pip as dev dependency and ipython as optional dependency Move pip as a dev dependency and ipython as an optional dependency Apr 21, 2023
@seisman seisman requested a review from weiji14 April 21, 2023 04:35
@seisman seisman removed the needs review This PR has higher priority and needs review. label Apr 21, 2023
@seisman seisman merged commit 9a497e1 into main Apr 21, 2023
@seisman seisman deleted the fix-envs branch April 21, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants