Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Mar 6, 2023

Description of proposed changes

grid.attrs.pop("actual_range") raises a KeyError exception if the actual_range attribute doesn't exist. This PR fixes the issue by setting the default return value to None.

Address my comment #2398 (comment).

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Mar 6, 2023
@seisman seisman added this to the 0.9.0 milestone Mar 6, 2023
@seisman seisman changed the title Do not raise a KeyError if actual_range attributes don't exist Do not raise a KeyError exception if attribute actual_range doesn't exist Mar 6, 2023
@seisman seisman merged commit 8d165c1 into main Mar 6, 2023
@seisman seisman deleted the pop-attrs branch March 6, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants