Skip to content

Add a gallery example showing how to use advanced grdgradient via the "azimuth" & "normalize" parameters #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
seisman merged 60 commits into from
Mar 15, 2023
Merged

Add a gallery example showing how to use advanced grdgradient via the "azimuth" & "normalize" parameters #2354

seisman merged 60 commits into from
Mar 15, 2023
+62 −0

Conversation

@jhtong33
Copy link
Contributor

@jhtong33 jhtong33 commented Feb 8, 2023 •
edited by weiji14
Loading

Description of proposed changes
This PR aims to add a gallery example showing how to use advanced grdgradient via the azimuth & normalize parameters

Because the gallery/images/grdgradient.py already showed how to use radiance parameter, I choose azimuth as the example.

Preview at https://pygmt-dev--2354.org.readthedocs.build/en/2354/gallery/images/grdgradient_shading.html

grdgradient azimuth and normalize gallery example

Fixes #2322

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

jhtong33 and others added 30 commits January 11, 2023 12:44
@jhtong33
alias surface.py T=tensor
9007170
@jhtong33
surface.py add tension documnets
4b62f0e
@jhtong33
surface add -L -M -C:
803a278
@jhtong33 @weiji14
Apply suggestions from code review
fc0ba08 
Co-authored-by: Wei Ji <[email protected]>
@jhtong33
surface add document: limit upper & lower
fbe59e2
@jhtong33 @weiji14
Apply suggestions from code review
6cf98c8 
Co-authored-by: Wei Ji <[email protected]>
@jhtong33 @weiji14
Apply suggestions from code review
f917d9d 
Co-authored-by: Wei Ji <[email protected]>
/format
add6d0a
format
5c77c5f
@jhtong33
format bold and space
ae90cc3
@jhtong33 @yvonnefroehlich
Apply suggestions from code review
9d19405 
Co-authored-by: Yvonne Fröhlich <[email protected]>
@jhtong33 @yvonnefroehlich
Apply suggestions from code review
38e80c0 
Co-authored-by: Yvonne Fröhlich <[email protected]>
@jhtong33
add Unit links
68f7fbf
@jhtong33
add Unit links with :
78f721c
@jhtong33
add Unit links
15680a7
@jhtong33
Merge branch 'GenericMappingTools:main' into main
d05a7a5
@jhtong33
adding grdgradient_shading
c6fcf49
@actions-bot
[format-command] fixes
bffc4c2
@jhtong33 @weiji14 @yvonnefroehlich
Apply suggestions from code review
8c9505a 
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Yvonne Fröhlich <[email protected]>
@jhtong33
code finish
e5f5c54
@jhtong33
Merge branch 'GenericMappingTools:main' into mini_branch
1fdc625
@weiji14
Merge branch 'main' into main
2897d2f
@jhtong33 @seisman
Apply suggestions from code review
3256f2b 
Co-authored-by: Dongdong Tian <[email protected]>
@jhtong33
add tension more infomation
2d433b0
@jhtong33
Merge branch 'main' of github.com:JingHuiTong/pygmt into main
1492de9
@jhtong33
mini_branch/ surface.py T=tension more information
3c8fd2c
@jhtong33
Fix conflicts
968bda3
@jhtong33
Merge remote-tracking branch 'origin/main' into main
6136b8a
@actions-bot
[format-command] fixes
5653ef1
@jhtong33 @weiji14 @yvonnefroehlich
Apply suggestions from code review
8da18ee 
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Yvonne Fröhlich <[email protected]>
weiji14
weiji14 reviewed Mar 8, 2023
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JingHuiTong! Just a few more comments/suggestions. It'll be good to include this in the upcoming PyGMT v0.9.0 release by the end of March, so we'll make sure to get this merged before then!

seisman
seisman reviewed Mar 14, 2023
View reviewed changes
yvonnefroehlich
yvonnefroehlich reviewed Mar 14, 2023
View reviewed changes
@jhtong33 @yvonnefroehlich @seisman
Apply suggestions from code review
ad689a7 
Co-authored-by: Yvonne Fröhlich <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
weiji14
weiji14 approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to fix the Style Checks (run \format), but this looks ready for final review!

@weiji14 weiji14 added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Mar 14, 2023
yvonnefroehlich
yvonnefroehlich reviewed Mar 14, 2023
View reviewed changes
@maxrjones maxrjones mentioned this pull request Mar 14, 2023
Closed
36 tasks
seisman
seisman reviewed Mar 15, 2023
View reviewed changes
JingHuiTong and others added 2 commits March 15, 2023 09:23
projection size
7d420ad
@jhtong33 @seisman @yvonnefroehlich
Apply suggestions from code review
4cb2dbe 
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Yvonne Fröhlich <[email protected]>
@jhtong33
Copy link
Contributor Author

jhtong33 commented Mar 15, 2023

/format

seisman
seisman approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@seisman seisman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the nice gallery example @JingHuiTong.

seisman
seisman reviewed Mar 15, 2023
View reviewed changes
yvonnefroehlich
yvonnefroehlich approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@yvonnefroehlich yvonnefroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thanks @JingHuiTong for putting efforts into contributing this gallery example 🙂 and also for considering the review comments!

@seisman seisman mentioned this pull request Mar 15, 2023
Closed
@seisman seisman merged commit 139c97e into GenericMappingTools:main Mar 15, 2023
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 15, 2023
@seisman
Copy link
Member

seisman commented Mar 15, 2023

@JingHuiTong As mentioned in #2321 (comment), if you like, you can open a new pull request to add yourself to the AUTHORS.md file.

@seisman seisman mentioned this pull request Mar 15, 2023
Merged
11 tasks
@jhtong33
Copy link
Contributor Author

jhtong33 commented Mar 16, 2023

@JingHuiTong As mentioned in #2321 (comment), if you like, you can open a new pull request to add yourself to the AUTHORS.md file.

WOW! Undoubtedly YES! I have already open new PR #2430

@jhtong33 jhtong33 deleted the grdgradient branch July 18, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seisman seisman seisman approved these changes

@michaelgrund michaelgrund michaelgrund approved these changes

@weiji14 weiji14 weiji14 approved these changes

@yvonnefroehlich yvonnefroehlich yvonnefroehlich approved these changes

Assignees

@jhtong33 jhtong33

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

Example showing grdgradient shading outputs with different radiance or normalize values

6 participants

@jhtong33 @michaelgrund @yvonnefroehlich @seisman @weiji14 @actions-bot