Skip to content

NEP29: Test PyGMT on NumPy 1.23 and 1.21 #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weiji14 merged 2 commits into from
Aug 17, 2022
Merged

NEP29: Test PyGMT on NumPy 1.23 and 1.21 #2057

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdefc27
NEP29: Test PyGMT on NumPy 1.23
weiji14 Aug 17, 2022
c0bf124
Set minimum NumPy version to 1.21 for CI tests
weiji14 Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,14 @@ jobs:
isDraft: true
- os: windows-latest
isDraft: true
# Pair Python 3.8 with NumPy 1.20 and Python 3.10 with NumPy 1.22
# Only install optional packages on Python 3.10/NumPy 1.22
# Pair Python 3.8 with NumPy 1.20 and Python 3.10 with NumPy 1.23
# Only install optional packages on Python 3.10/NumPy 1.23
include:
- python-version: '3.8'
numpy-version: '1.20'
Copy link
Member Author

@weiji14 weiji14 Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question. Do we want to just set our minimum tested NumPy version to 1.21 in the CI since xarray doesn't work with Numpy 1.20 and they won't be releasing a patch as per pydata/xarray#6818 (comment)? Due date to drop Numpy 1.20 is Jan 31, 2023 (5 months) per https://numpy.org/neps/nep-0029-deprecation_policy.html#drop-schedule.

Copy link
Contributor

@willschlitzer willschlitzer Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think setting numpy to v1.21 makes sense. I'm not sure what the plan is for the pygmt v0.8 release, but I don't think we'll have 2 releases before January 2023, so our next release should be up to date on minimum versions.

Copy link
Member Author

@weiji14 weiji14 Aug 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Just to be clear, the suggestion is to just set NumPy 1.21 for the Continuous Integration (CI) so that the unit tests pass. We shouldn't change the minimum supported NumPy mentioned in https://github.com/GenericMappingTools/pygmt/tree/v0.7.0#compatibility-with-gmtpythonnumpy-versions until after Jan 2023 (though users using NumPy 1.20 will need to figure out the xarray dependency themselves).

optional-packages: ''
- python-version: '3.10'
numpy-version: '1.22'
numpy-version: '1.23'
optional-packages: 'geopandas ipython'
timeout-minutes: 30
defaults:
Expand Down