Skip to content

Conversation

@weiji14
Copy link
Member

@weiji14 weiji14 commented May 5, 2022

Description of proposed changes

Look GitHub Actions has some public beta runners available:

So let's test it out on the GMT Dev Tests workflow!

Also updating the cron tab to run GMT Dev Tests on Monday/Wednesday/Friday only. A bit annoying to have the tests failing everyday, especially during the weekend. See also #1833 (comment) about having less frequent tests. Edit: cherry-picked this to #1922

Supersedes #1105.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label May 5, 2022
@weiji14 weiji14 added this to the 0.7.0 milestone May 5, 2022
@weiji14 weiji14 self-assigned this May 5, 2022
@weiji14 weiji14 marked this pull request as ready for review May 6, 2022 00:43
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed final review call This PR requires final review and approval from a second reviewer labels May 6, 2022
@seisman
Copy link
Member

seisman commented May 6, 2022

It seems that the macOS-12.0 agent doesn't respond:
https://github.com/GenericMappingTools/pygmt/runs/6315841035?check_suite_focus=true

@seisman seisman self-requested a review May 6, 2022 08:00
@weiji14 weiji14 marked this pull request as draft May 6, 2022 21:27
@weiji14 weiji14 marked this pull request as ready for review May 6, 2022 21:28
@weiji14
Copy link
Member Author

weiji14 commented May 6, 2022

Interesting. I saw that the macos-12.0 didn't repond either when in PR at google/santa#798, but their macos-12.0 CI worked in the main branch after merging. Maybe one of those permissions thing again. Do you think we shoud just merge and see?

@seisman
Copy link
Member

seisman commented May 7, 2022

Interesting. I saw that the macos-12.0 didn't repond either when in PR at google/santa#798, but their macos-12.0 CI worked in the main branch after merging. Maybe one of those permissions thing again. Do you think we shoud just merge and see?

I've applied your changes to the main branch of my own fork (https://github.com/seisman/pygmt). The macOS-12.0 runner still doesn't respond (https://github.com/seisman/pygmt/runs/6332825323?check_suite_focus=true).

@weiji14
Copy link
Member Author

weiji14 commented May 7, 2022

Ok, let's wait until next week and try again.

@seisman
Copy link
Member

seisman commented May 10, 2022

Perhaps we can pick the commits fdd64ac and 6b9c5ab into #1833, so that we run full tests 3 times a week, then #1833 may be OK to merge?

@weiji14
Copy link
Member Author

weiji14 commented May 10, 2022

Perhaps we can pick the commits fdd64ac and 6b9c5ab into #1833, so that we run full tests 3 times a week, then #1833 may be OK to merge?

I've cherry-picked the Mon/Wed/Fri crontab to #1922. Would prefer the full tests in #1833 to run on a less frequent schedule, but let's discuss that in #1833.

@weiji14 weiji14 changed the title Update GMT Dev Tests workflow to test on macOS-12.0 Update GMT Dev Tests workflow to test on macOS-12.0 and ubuntu-22.04 May 10, 2022
@weiji14 weiji14 marked this pull request as draft May 10, 2022 18:13
@weiji14 weiji14 marked this pull request as ready for review May 11, 2022 13:44
@weiji14
Copy link
Member Author

weiji14 commented May 11, 2022

Testing on Ubuntu 22.04 (Jammy Jellyfish) at https://github.com/GenericMappingTools/pygmt/runs/6389148872?check_suite_focus=true, seems to be running. The macOS-12.0 still seems stuck though.

@seisman seisman marked this pull request as draft June 1, 2022 05:26
@seisman seisman marked this pull request as ready for review June 1, 2022 05:26
@weiji14 weiji14 marked this pull request as draft June 9, 2022 04:10
@weiji14 weiji14 marked this pull request as ready for review June 9, 2022 04:10
@weiji14 weiji14 marked this pull request as draft June 9, 2022 14:52
@seisman seisman marked this pull request as ready for review June 14, 2022 05:01
@seisman seisman marked this pull request as draft June 14, 2022 06:50
@weiji14 weiji14 marked this pull request as ready for review June 14, 2022 14:34
@weiji14
Copy link
Member Author

weiji14 commented Jun 14, 2022

@weiji14 weiji14 marked this pull request as draft June 14, 2022 18:08
@weiji14 weiji14 closed this Jun 14, 2022
@weiji14 weiji14 reopened this Jun 14, 2022
@weiji14 weiji14 marked this pull request as ready for review June 14, 2022 18:09
@weiji14 weiji14 marked this pull request as draft June 14, 2022 18:10
@weiji14 weiji14 marked this pull request as ready for review June 14, 2022 18:11
@weiji14
Copy link
Member Author

weiji14 commented Jun 14, 2022

@seisman, seems to be working now (see https://github.com/GenericMappingTools/pygmt/runs/6886313572?check_suite_focus=true). Just realized at #1918 (comment) that it was a typo 😅 Should be macos-12, not macos-12.0 🤷

@weiji14 weiji14 changed the title Update GMT Dev Tests workflow to test on macOS-12.0 and ubuntu-22.04 Update GMT Dev Tests workflow to test on macOS-12 and ubuntu-22.04 Jun 15, 2022
@weiji14 weiji14 merged commit 1067fa3 into main Jun 15, 2022
@weiji14 weiji14 deleted the ci/test-macos-12 branch June 15, 2022 03:09
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…enericMappingTools#1918)

* Update GMT Dev Tests workflow to test on macOS-12
* Update GMT Dev Tests workflow to test on ubuntu-22.04
* Two jobs are ran on Ubuntu for draft PRs, not one

Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants