-
Notifications
You must be signed in to change notification settings - Fork 234
Update GMT Dev Tests workflow to test on macOS-12 and ubuntu-22.04 #1918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It seems that the macOS-12.0 agent doesn't respond: |
|
Interesting. I saw that the macos-12.0 didn't repond either when in PR at google/santa#798, but their macos-12.0 CI worked in the main branch after merging. Maybe one of those permissions thing again. Do you think we shoud just merge and see? |
I've applied your changes to the main branch of my own fork (https://github.com/seisman/pygmt). The macOS-12.0 runner still doesn't respond (https://github.com/seisman/pygmt/runs/6332825323?check_suite_focus=true). |
|
Ok, let's wait until next week and try again. |
|
Testing on Ubuntu 22.04 (Jammy Jellyfish) at https://github.com/GenericMappingTools/pygmt/runs/6389148872?check_suite_focus=true, seems to be running. The macOS-12.0 still seems stuck though. |
|
The macos-12 runners should be generally available now, see https://github.blog/changelog/2022-06-13-github-actions-macos-12-for-github-hosted-runners-is-now-generally-available/ |
|
@seisman, seems to be working now (see https://github.com/GenericMappingTools/pygmt/runs/6886313572?check_suite_focus=true). Just realized at #1918 (comment) that it was a typo 😅 Should be |
…enericMappingTools#1918) * Update GMT Dev Tests workflow to test on macOS-12 * Update GMT Dev Tests workflow to test on ubuntu-22.04 * Two jobs are ran on Ubuntu for draft PRs, not one Co-authored-by: Dongdong Tian <[email protected]>
Description of proposed changes
Look GitHub Actions has some public beta runners available:
So let's test it out on the GMT Dev Tests workflow!
Also updating the cron tab to run GMT Dev Tests on Monday/Wednesday/Friday only. A bit annoying to have the tests failing everyday, especially during the weekend. See also #1833 (comment) about having less frequent tests.Edit: cherry-picked this to #1922Supersedes #1105.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version