Skip to content

Move matplotlib import inside the check_figures_equal function #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seisman merged 3 commits into from
Apr 13, 2022
Merged

Move matplotlib import inside the check_figures_equal function #1877

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a820efc
Move matplotlib import inside the check_figures_equal function
seisman Apr 11, 2022
9ef4033
Enable the cache data workflow temporarily
seisman Apr 11, 2022
faf5f00
Disable data cache in PR
seisman Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cache_data.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Cache data

on:
# Uncomment the 'pull_request' line below to manually re-cache data artifacts
# pull_request:
pull_request:
# Schedule runs on 12 noon every Sunday
schedule:
- cron: '0 12 * * 0'
Expand Down Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Install dependencies
run: |
mamba install gmt=6.3.0 numpy pandas xarray netCDF4 packaging \
build matplotlib
build

# Install the package that we want to test
- name: Install the package
Expand Down
5 changes: 3 additions & 2 deletions pygmt/helpers/testing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import os
import string

from matplotlib.testing.compare import compare_images
from pygmt.exceptions import GMTImageComparisonFailure
from pygmt.io import load_dataarray
from pygmt.src import which
Expand Down Expand Up @@ -77,7 +76,9 @@ def check_figures_equal(*, extensions=("png",), tol=0.0, result_dir="result_imag
KEYWORD_ONLY = inspect.Parameter.KEYWORD_ONLY

def decorator(func):
import pytest # pylint: disable=import-outside-toplevel
# pylint: disable=import-outside-toplevel
import pytest
from matplotlib.testing.compare import compare_images

os.makedirs(result_dir, exist_ok=True)
old_sig = inspect.signature(func)
Expand Down