Skip to content

Conversation

@michaelgrund
Copy link
Member

Description of proposed changes

  • Remove Python 3.7 from our CI jobs
  • Bump the minimum required Python version to 3.8 in the documentation
  • Remove Python 3.7 from setup.py

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund added the deprecation Deprecating a feature label Dec 19, 2021
@michaelgrund michaelgrund added this to the 0.6.0 milestone Dec 19, 2021
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michaelgrund! Just some suggestions to put quotes around the version numbers (otherwise Python 3.10 will be read as Python 3.1 in the future, see #1577). I'll reduce the diffs in #1577 a little so that it won't conflict with this PR (edit: done at fca7a68).

weiji14 added a commit that referenced this pull request Dec 20, 2021
@weiji14 weiji14 changed the title Drop Python 3.7 on Dec. 26, 2021 NEP29: Set minimum required version to Python 3.8+ Dec 20, 2021
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michaelgrund, I've changed the PR's title and updated the required checks at https://github.com/GenericMappingTools/pygmt/settings. Just wait for a second approval before merging.

@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Dec 20, 2021
@seisman seisman merged commit 90df7b2 into main Dec 20, 2021
@seisman seisman deleted the drop-py37 branch December 20, 2021 11:46
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 20, 2021
weiji14 added a commit that referenced this pull request Dec 20, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation Deprecating a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants