Unpin GMT dev version from conda-forge/label/dev on Windows #1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the pin to GMT 6.3 in the ci_tests_dev.yaml file so that GMT 6.4 and above will be installed instead.
weiji14
added
maintenance
seisman
approved these changes
Dec 5, 2021
Member
seisman
left a comment
seisman
left a comment
There was a problem hiding this comment.
Looks good to me. The 6 failing tests seem unrelated.
This reverts commit 01950d7.
5 tasks
Member
Author
|
Just noticed that GitHub Actions has Windows Server 2022 images in beta (see actions/runner-images#4488), so giving it a try at c8255e4 😁 |
weiji14
added
the
final review call
willschlitzer
approved these changes
Dec 6, 2021
weiji14
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…appingTools#1645) Remove the pin to GMT 6.3 in the ci_tests_dev.yaml file so that GMT 6.4 and above will be installed instead. Also run tests on Windows Server 2022.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Remove the pin to GMT 6.3 in the ci_tests_dev.yaml file so that GMT 6.4 and above will be installed instead. A recent version bump was made in conda-forge/gmt-feedstock#190.
Also run tests on Windows Server 2022.
For context, the pin was originally made deeafad to fix a problem with the conda/mamba resolver (see #841 (comment)). Let's see if unpinning works. For even more context on why we install GMT dev from conda-forge on Windows instead of building GMT from source, see #755.
This should hopefully fix a recent installation error on GMT Dev Tests for Windows caused by a missing compatible version of GDAL, e.g. at https://github.com/GenericMappingTools/pygmt/runs/4419658321?check_suite_focus=true#step:9:41:
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version