Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Sep 25, 2021

Description of proposed changes

Address #1543.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Sep 25, 2021
@seisman seisman added this to the 0.5.0 milestone Sep 25, 2021
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge directly.

@seisman seisman merged commit 09847a7 into main Sep 25, 2021
@seisman seisman deleted the pin-dvc-2.3.0 branch September 25, 2021 22:55
seisman added a commit that referenced this pull request Oct 2, 2021
@seisman seisman mentioned this pull request Oct 2, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants