Add alias name convention to CONTRIBUTING.md #1256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiji14
reviewed
May 3, 2021
Member
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
Just one comment, otherwise looks good!
Co-authored-by: Wei Ji <[email protected]>
weiji14
approved these changes
May 3, 2021
seisman
approved these changes
May 4, 2021
michaelgrund
approved these changes
May 4, 2021
willschlitzer
approved these changes
May 4, 2021
Contributor
willschlitzer
left a comment
willschlitzer
left a comment
There was a problem hiding this comment.
Looks good!
"Is 'aeiou' the term to describe when words are bridged by vowels?" -Me, just now 🤦♂️
Member
Author
|
Sorry for forgetting to shorten the commit message when merging... |
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
* Add alias name convention to CONTRIBUTING.md * Update CONTRIBUTING.md Co-authored-by: Wei Ji <[email protected]> Co-authored-by: Wei Ji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR adds a convention for when to separate words in aliases by an underscore to CONTRIBUTING.md. Originally suggested by @weiji14 in #1190 (comment).
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version