Skip to content

Conversation

@weiji14
Copy link
Member

@weiji14 weiji14 commented Apr 27, 2021

Description of proposed changes

The workflow ran on every GitHub issue and pull request comments. This patch ensures that the the slash command dispatch workflow is triggered by Pull Request comments only, thereby helping to conserve some CI resources (since each slash command dispatch takes 16-20s to run).

image

References:

Patches #646

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

The workflow ran on every GitHub issue and pull request
comments. This patch ensures that the the slash command
dispatch workflow is triggered by Pull Request comments
only. Patches #646.
@weiji14 weiji14 added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 27, 2021
@weiji14 weiji14 self-assigned this Apr 27, 2021
@weiji14 weiji14 merged commit 91e3648 into master Apr 27, 2021
@weiji14 weiji14 deleted the run-slash-command-on-pr-only branch April 27, 2021 23:58
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…nericMappingTools#1248)

The workflow ran on every GitHub issue and pull request
comments. This patch ensures that the the slash command
dispatch workflow is triggered by Pull Request comments
only. Patches GenericMappingTools#646.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants