Skip to content

Fix ModuleNotFoundError error when IPython is not installed #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weiji14 merged 4 commits into from
May 7, 2021
Merged

Fix ModuleNotFoundError error when IPython is not installed #1247

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79f329b
Fix the exception when IPython is not installed
seisman Apr 27, 2021
db36410
Install IPython on the Python 3.9/NumPy 1.20 test build only
seisman Apr 27, 2021
1254c8a
Merge branch 'master' into fix-ipython
seisman May 3, 2021
7b2e2ba
Revert "Install IPython on the Python 3.9/NumPy 1.20 test build only"
seisman May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pygmt/figure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

try:
import IPython
except KeyError:
except ModuleNotFoundError:
IPython = None # pylint: disable=invalid-name
Copy link
Member

@weiji14 weiji14 Apr 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see any reporting on Codecov (because the codecov upload doesn't work with test failures due to #1217), but I'm assuming this line has code coverage?



Expand Down