Skip to content

Conversation

@michaelgrund
Copy link
Member

@michaelgrund michaelgrund commented Mar 26, 2021

Description of proposed changes

Found further passages in the coastlines tutorial where "argument" is incorrectly used. It's replaced by "parameter" in this PR.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Found another passage in the coastlines tutorial where "argument"  is incorrectly used. It's replaced by "parameter" in this PR.
@michaelgrund michaelgrund added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Mar 26, 2021
@seisman seisman added this to the 0.4.0 milestone Mar 26, 2021
@core-man
Copy link
Member

Great~ Only one minor additional revision


Change 10i to be 10c?

fig.basemap(region="g", projection="W10i", frame=True)

@michaelgrund
Copy link
Member Author

Great~ Only one minor additional revision

Change 10i to be 10c?

fig.basemap(region="g", projection="W10i", frame=True)

Of couse 😉. Will change it and let's have a look how it appears in sphinx.

@core-man
Copy link
Member

Looks good on my phone.

@michaelgrund
Copy link
Member Author

Looks good on my phone.

Not here, some of the frame annotations are hidden. Not sure why.

sphx_glr_coastlines_005

@seisman
Copy link
Member

seisman commented Mar 26, 2021

Let's change it to 15c:

image

@core-man
Copy link
Member

core-man commented Mar 26, 2021

I can see the frame annotations on my phone now.

@seisman seisman merged commit a74fd39 into master Mar 26, 2021
@seisman seisman deleted the update-coastlines-tutorial branch March 26, 2021 18:04
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…gTools#1128)

* Replace argument with parameter in coastlines tutorial
* Replace 10i by 15c in projection parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants