Wrap blockmean #1092
Merged
Wrap blockmean #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
reviewed
Mar 22, 2021
seisman
reviewed
Mar 22, 2021
weiji14
reviewed
Mar 22, 2021
2 tasks
weiji14
reviewed
Mar 22, 2021
Member
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
Just one very minor point on moving _blockm to the top of the file, otherwise well done!
weiji14
approved these changes
Mar 22, 2021
Member
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
Thanks Meghan! Really appreciate having another data processing module added to PyGMT's toolkit 😄
weiji14
added
the
final review call
seisman
removed
the
final review call
5 tasks
seisman
added a commit
that referenced
this pull request
Oct 3, 2021
The alias of d is nodata in other modules, but was incorrectly set to data in blockmean and blockmode. This PR fixes the problem. blockmode was wrapped in #1456 (after v0.4.1), blockmean was wrapped in #1092 but the wrong alias was added in #1500 (after v0.4.1). Thus, the change won't go into the deprecation cycle.
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
* Rename blockmedian.py to blockm.py * Refactor blockmedian to support mean and mode * Wrap method blockmean * Add tests for blockmean method Co-authored-by: Dongdong Tian <[email protected]> Co-authored-by: Wei Ji <[email protected]>
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…ngTools#1563) The alias of d is nodata in other modules, but was incorrectly set to data in blockmean and blockmode. This PR fixes the problem. blockmode was wrapped in GenericMappingTools#1456 (after v0.4.1), blockmean was wrapped in GenericMappingTools#1092 but the wrong alias was added in GenericMappingTools#1500 (after v0.4.1). Thus, the change won't go into the deprecation cycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR wraps the blockmean module. Some changes involved in this PR:
blockmedianmethod is moved to_blockmblockmedianandblockmeancall_blockmwith theblock_methodparameterpygmt/src/blockmedian.pyis renamed topygmt/src/blockm.pyfor simplicity given the similarities between these three methods. I think this is simpler (more pythonic) than having each in separate modules and importing_blockmfrom a fourth module, but feedback is welcome if others feel that Should data processing functions have their own modules? #807 should be more strictly adhered to.Addresses #1091
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version