Let psxy[z] -Sr accept width/height on command line #4164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not given, then we read from data file, but this PR will allow you to give -Sr2c/1c, for instance.
joa-quim
approved these changes
Sep 4, 2020
Member
|
Looks good to me. Perhaps degenerate to squares if only -Srwidth is given, or at least improve the error/warning messages. Currently, the warning message is a little unclear to me. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not given, then we read from data file, but this PR will allow you to give -Sr2c/1c, for instance. We almost had that in the code as the parsing correctly obtains the dimensions, but then we overrode that and insisted we always must read from file. Will do -SRwidth/height/radius next. All test pass as before.