Forgot the other place where locking occurred #3785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now both places where lockfiles are used avoids URL queries. Closes #3765.
seisman
approved these changes
Jul 31, 2020
seisman
pushed a commit
that referenced
this pull request
Aug 1, 2020
Now both places where lockfiles are used avoids URL queries. Closes #3765.
seisman
added a commit
that referenced
this pull request
Aug 1, 2020
* Let libcurl downloads be managed via lockfiles (#3735) * Try to use filelock for downloads We want to avoid race conditions on gmt_data_server.txt and gmt_hash_server.txt. * Update gmt_remote.c * Delete a failing gmt_data_server.txt file so it can be regenerated If for whatever reason the gmt_data_server.txt ends up blank, reading will fail. Rather than just complain about it, we now delete the file since we (a) know it is broken and (b) unless it is removed we will not attempt to refresh it for another cycle (by default 24 hours). * Exempt URL queries from having lock files (#3768) Since the URL of a quiery is not a good file name, we do not create an advisory lock file for such downloads. Addresses #3765 hopefully. * Checked wrong string for URL (#3780) Hopefully fixes #3765. * Forgot the other place where locking occurred (#3785) Now both places where lockfiles are used avoids URL queries. Closes #3765. * Must close file before delete it (#3804) Co-authored-by: Paul Wessel <[email protected]> Co-authored-by: Joaquim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now both places where lockfiles are used avoids URL queries. Closes #3765.