Make sure we only try to download input files #3552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In gmtapi_next_io_source we call gmt_download_file_if_not_found wihtout checking if it is an input file first. Not sure if this is causing any problems but now isolated inside an if-test.
seisman
approved these changes
Jun 28, 2020
Member
Author
|
Did this prevent the problem you had with output.txt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In gmtapi_next_io_source we call gmt_download_file_if_not_found wihtout checking if it is an input file first. Not sure if this is causing any problems but now isolated inside an if-test. Addresses the issue in #3532.